[webkit-reviews] review granted: [Bug 50216] [WINCE] Add WebView : [Attachment 75116] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 50216: [WINCE] Add WebView
https://bugs.webkit.org/show_bug.cgi?id=50216

Attachment 75116: Patch
https://bugs.webkit.org/attachment.cgi?id=75116&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75116&action=review

You have a bunch of unnecessary parameter names in WebView.h.

I'm not sure why the style bot didn't catch the style issues.

> WebKit/wince/WebView.cpp:245
> +    if (::GetUpdateRect(hWnd, &updateRect, false)) {

Can you use an early return here?

> WebKit/wince/WebView.h:61
> +    WebCore::FrameView *view() const;

Misplaced *.

> WebKit/wince/WebView.h:80
> +    static LRESULT CALLBACK WebViewWndProc(HWND hWnd, UINT message, WPARAM
wParam, LPARAM lParam);
> +    LRESULT WndProc(HWND, UINT, WPARAM, LPARAM);

These should start with lowercase letters.