[webkit-reviews] review denied: [Bug 50077] Fix rendering of speech button when setting the attribute dynamically. : [Attachment 74873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 06:53:54 PST 2010


Kent Tamura <tkent at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 50077: Fix rendering of speech button when setting the attribute
dynamically.
https://bugs.webkit.org/show_bug.cgi?id=50077

Attachment 74873: Patch
https://bugs.webkit.org/attachment.cgi?id=74873&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74873&action=review

> LayoutTests/fast/speech/input-appearance-speechbutton.html:37
> +var inputWithAttribute = document.createElement('input');
> +inputWithAttribute.setAttribute('x-webkit-speech', 'x-webkit-speech');
> +document.body.appendChild(inputWithAttribute);

This doesn't test the new code.  We should call setAttribute() after
document.body.appendChild().


More information about the webkit-reviews mailing list