[webkit-reviews] review canceled: [Bug 50015] Move regex parsing and fallback handling to runtime/RegExp.cpp : [Attachment 74747] proposed patch

[bugzilla-daemon at webkit.org]

Peter Varga <pvarga at inf.u-szeged.hu> has canceled Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 50015: Move regex parsing and fallback handling to runtime/RegExp.cpp
https://bugs.webkit.org/show_bug.cgi?id=50015

Attachment 74747: proposed patch
https://bugs.webkit.org/attachment.cgi?id=74747&action=review

------- Additional Comments from Peter Varga <pvarga at inf.u-szeged.hu>
Hi Gavin,

> What do you think of adding an enum to explicitly delineate the states?
Adding an enum instead of m_useInterpreter variable is sensible and it mades
the code clearer.
I updated the patch.

> we should probably remove the compile method
I didn't remove the compile method. I think it makes the code seperatable and
now it makes the logic of handling
RegExp states flexible.

> we should probably also remove the following comment from the header
I removed this comment. At first the solving of the FIXME looked pointless and
I didn't modify it.

Your suggestion about the modification of RegExp::create needs more
investigation because It needs changes
in those classes which implement the handling of regular expressions in
runtime.

Regards,
Peter