[webkit-reviews] review requested: [Bug 50195] Progress and meter elements should take a form in their constructor like any other form control. : [Attachment 75136] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 30 06:35:07 PST 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 50195: Progress and meter elements should take a form in their constructor
like any other form control.
https://bugs.webkit.org/show_bug.cgi?id=50195

Attachment 75136: Patch.
https://bugs.webkit.org/attachment.cgi?id=75136&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Added tests and also touch HTMLTagNames.in, to trigger re-generating
HTMLElementFactory.cpp, to keep buildbots happy.

Please note that the tests are passing even without this patch because
HTMLFormControlElement::insertedIntoTree will associate the form control with
the form if the form was inserted first. HTMLFormElement::insertedIntoDocument
will associate the form control with the form if the form is inserted after the
form control.


More information about the webkit-reviews mailing list