[webkit-reviews] review granted: [Bug 50071] [Qt] Fix compilation with !ENABLE(OFFLINE_WEB_APPLICATIONS) and !ENABLE(JAVASCRIPT_DEBUGGER) and !ENABLE(TILED_BACKING_STORE) for WebKit2 : [Attachment 74870] 2nd try, resolve conflict with trunk
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 30 01:12:07 PST 2010
Csaba Osztrogonac <ossy at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 50071: [Qt] Fix compilation with !ENABLE(OFFLINE_WEB_APPLICATIONS) and
!ENABLE(JAVASCRIPT_DEBUGGER) and !ENABLE(TILED_BACKING_STORE) for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50071
Attachment 74870: 2nd try, resolve conflict with trunk
https://bugs.webkit.org/attachment.cgi?id=74870&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74870&action=review
> WebKit2/ChangeLog:6
> + [Qt] Fix compilation with !ENABLE(OFFLINE_WEB_APPLICATIONS) and
!ENABLE(JAVASCRIPT_DEBUGGER) and
> + !ENABLE(TILED_BACKING_STORE) for WebKit2
Please remove !ENABLE(JAVASCRIPT_DEBUGGER) from ChangeLog, because there isn't
any ENABLE(JAVASCRIPT_DEBUGGER) guard in this patch. :) Otherwise LGTM, r=me.
More information about the webkit-reviews
mailing list