[webkit-reviews] review denied: [Bug 47311] Add layout tests for Entry.getMetadata (FileSystem API) : [Attachment 71481] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 47311: Add layout tests for Entry.getMetadata (FileSystem API)
https://bugs.webkit.org/show_bug.cgi?id=47311

Attachment 71481: Patch
https://bugs.webkit.org/attachment.cgi?id=71481&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=71481&action=review

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:223
> +		   var entryMetadataString = 'this.environment["' + symbol +
'"]';

Might be better to make 'this.environment["' + symbol + '"]' a helper function
in order to simplify the code.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:230
> +		   this.errorCallback();

Probably we should continue to run next test even we fail the current test
unless we encounter a severe error that cannot be recoverable,

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:232
> +	    };

'}' not aligned correctly.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:324
> +	    };

ditto.

> LayoutTests/fast/filesystem/resources/op-tests-helper.js:331
> +	       // Record rounded start date (current time minus 999 msec) here
for the comparison. Entry.getMetadata() may return motd in seconds accuracy
while new Date() is milliseconds accuracy.

What is motd?