[webkit-reviews] review denied: [Bug 50195] Progress and meter elements should take a form in their constructor like any other form control. : [Attachment 75090] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 17:38:37 PST 2010


Darin Adler <darin at apple.com> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 50195: Progress and meter elements should take a form in their constructor
like any other form control.
https://bugs.webkit.org/show_bug.cgi?id=50195

Attachment 75090: Patch.
https://bugs.webkit.org/attachment.cgi?id=75090&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75090&action=review

review- because this bug does require a test case

> WebCore/ChangeLog:8
> +	   No new tests since this is a code cleanup only.

That is incorrect. The reason form elements get a form argument is so that they
are correctly associated with the form in cases when the form is not an
ancestor of the form element. We need to construct a test case that
demonstrates this not occurring for meter elements before and happening
correctly for meter elements after the patch.


More information about the webkit-reviews mailing list