[webkit-reviews] review denied: [Bug 50189] [chromium] ContentLayerChromium shader should honor the platform Sk_x_SHIFT value instead of assuming BGRA color : [Attachment 75082] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 17:21:33 PST 2010


Kenneth Russell <kbr at google.com> has denied Grace Kloba <klobag at chromium.org>'s
request for review:
Bug 50189: [chromium] ContentLayerChromium shader should honor the platform
Sk_x_SHIFT value instead of assuming BGRA color
https://bugs.webkit.org/show_bug.cgi?id=50189

Attachment 75082: patch
https://bugs.webkit.org/attachment.cgi?id=75082&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75082&action=review

The code change looks fine (though the duplicated shader is a little
unfortunate) but the OOPS line about no new tests needs to be removed and the
patch regenerated or the commit queue will reject it.

> WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This line needs to be deleted.


More information about the webkit-reviews mailing list