[webkit-reviews] review denied: [Bug 50048] Need to initialize destination variables before calling GL : [Attachment 75075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 17:11:19 PST 2010


Kenneth Russell <kbr at google.com> has denied Gregg Tavares <gman at google.com>'s
request for review:
Bug 50048: Need to initialize destination variables before calling GL
https://bugs.webkit.org/show_bug.cgi?id=50048

Attachment 75075: Patch
https://bugs.webkit.org/attachment.cgi?id=75075&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
The code changes look fine, and sorry for the nitpick, but could you please
change your editor's settings to not modify existing whitespace, and regenerate
the patch? I've been advised by other WebKit reviewers that whitespace changes
should not be done in conjunction with code changes. It would be great if you
would file a separate bug and submit a patch just for the whitespace cleanups.


More information about the webkit-reviews mailing list