[webkit-reviews] review requested: [Bug 49998] Allow ports finer-grain control of when to enable accelerated compositing : [Attachment 75074] Patch adjusted per reviewer comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 15:42:28 PST 2010


Vangelis Kokkevis <vangelis at chromium.org> has asked  for review:
Bug 49998: Allow ports finer-grain control of when to enable accelerated
compositing
https://bugs.webkit.org/show_bug.cgi?id=49998

Attachment 75074: Patch adjusted per reviewer comments
https://bugs.webkit.org/attachment.cgi?id=75074&action=review

------- Additional Comments from Vangelis Kokkevis <vangelis at chromium.org>
Thanks for the review! I modified the patch to address the comments.
Specifically:
* Added an enum to the ChromeClient per Ken's and Simon's suggestion and
replaced individual calls by a single call.
* Added a canRender3dTransforms() method to the RenderLayerCompositor.	Media
queries as well as RenderLayer code that needs to know whether 3d transforms
are supported now call this method. I did leave the old
hasAcceleratedCompositing() method intact as it has a different, legitimate,
use.

Please take another look.


More information about the webkit-reviews mailing list