[webkit-reviews] review granted: [Bug 50185] Should be able to pause and resume downloads : [Attachment 75062] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 50185: Should be able to pause and resume downloads
https://bugs.webkit.org/show_bug.cgi?id=50185

Attachment 75062: Patch
https://bugs.webkit.org/attachment.cgi?id=75062&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75062&action=review

Might be better to name this resumptionData rather than resumeData so it
doesn’t sound like a verb phrase. But I guess the NSURLDownload method is
already named resumeData?

> WebKit2/UIProcess/Downloads/DownloadProxy.cpp:153
> +    if (!resumeData.isEmpty())
> +	   m_resumeData = WebData::create(resumeData.data(),
resumeData.size());

Would be nice to share this code instead of writing it twice.