[webkit-reviews] review granted: [Bug 48193] HTMLFormElement.elements doesn't include fieldsets : [Attachment 75054] Patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 48193: HTMLFormElement.elements doesn't include fieldsets
https://bugs.webkit.org/show_bug.cgi?id=48193

Attachment 75054: Patch.
https://bugs.webkit.org/attachment.cgi?id=75054&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75054&action=review

> WebCore/html/HTMLKeygenElement.h:39
> -    virtual bool isEnumeratable() const { return false; }
> +    virtual bool isEnumeratable() const { return true; }

You should instead just remove this member function entirely. The function
inherited from HTMLSelectElement already returns true, there is no need to
override.

> LayoutTests/fast/forms/script-tests/form-collection-elements.js:2
> +debug("This test does not add object element as a listed element. Separate
bug will be filed for that.");

I don’t think “separate bug will be filed” makes sense in a comment in the
test. Maybe you mean we’ll test that with a separate test?