[webkit-reviews] review granted: [Bug 49974] Web Inspector: Request JSON-serialized heap profile. : [Attachment 74788] Previous patch rebased

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 49974: Web Inspector: Request JSON-serialized heap profile.
https://bugs.webkit.org/show_bug.cgi?id=49974

Attachment 74788: Previous patch rebased
https://bugs.webkit.org/attachment.cgi?id=74788&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74788&action=review

> WebCore/bindings/js/ScriptHeapSnapshot.h:43
> +	   virtual ~OutputStream() {}

{ }

> WebCore/bindings/js/ScriptHeapSnapshot.h:53
> +    void writeJSON(OutputStream*) {}

{ }

> WebCore/inspector/front-end/HeapSnapshotView.js:73
> +    get _nameOrIndex()

We don't use getters for private fields.