[webkit-reviews] review denied: [Bug 47759] Crash while processing ill-formed <textPath> ouside of <text> : [Attachment 74958] Fix and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 29 11:58:35 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 47759: Crash while processing ill-formed <textPath> ouside of <text>
https://bugs.webkit.org/show_bug.cgi?id=47759

Attachment 74958: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=74958&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74958&action=review

Can you modify the test, then I'll r+ it.

> LayoutTests/svg/custom/invalid-text-content.svg:5
> +	   layoutTestController.dumpAsText();

Hm, how about removing dumpAsText() here and showing the actual render tree?
Would be easier to track the renderer creation with it...


More information about the webkit-reviews mailing list