[webkit-reviews] review granted: [Bug 24346] Remove Gears workaround in HTMLObjectElement.cpp : [Attachment 75005] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 24346: Remove Gears workaround in HTMLObjectElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=24346

Attachment 75005: Patch
https://bugs.webkit.org/attachment.cgi?id=75005&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75005&action=review

I think we can safely remove the entire rendererIsNeeded() call.  I don't see
any parent implementations preventing creation of renderers when a document
doesn't have a frame, but I believe that to be the case.  Frameless documents
won't have a FrameView, thus won't be rendered is my understanding.  I think
this whole override can be removed unless we have a test which proves
otherwise.

> WebCore/html/HTMLObjectElement.cpp:289
>      if (!frame)
>	   return false;

Are we sure this is still needed?