[webkit-reviews] review denied: [Bug 45491] when empty, clicking "down" on outer-spin-button returns "max value" : [Attachment 74988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 28 23:04:33 PST 2010


Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 45491: when empty, clicking "down" on outer-spin-button returns "max value"
https://bugs.webkit.org/show_bug.cgi?id=45491

Attachment 74988: Patch
https://bugs.webkit.org/attachment.cgi?id=74988&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74988&action=review

> WebCore/html/HTMLInputElement.cpp:1896
> +    // (e.g. Stepping-up for <input type="number" value="foo" step="any" />
=> "foo")

The example is wrong.  The value for <input type=number value=foo step=any> is
"" because of sanitization.


More information about the webkit-reviews mailing list