[webkit-reviews] review granted: [Bug 48101] Yarr gives different results for /(?:a*?){2, }/ : [Attachment 74965] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 28 12:46:21 PST 2010
Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 48101: Yarr gives different results for /(?:a*?){2,}/
https://bugs.webkit.org/show_bug.cgi?id=48101
Attachment 74965: The patch
https://bugs.webkit.org/attachment.cgi?id=74965&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74965&action=review
Any perf change? r+.
> JavaScriptCore/yarr/RegexInterpreter.cpp:1552
> + // then fix this up at the end! - simplyfying this should make it
mch clearer.
Typo: mch -> much. You may also want to file a bug on this and put the bug
number in the comment.
More information about the webkit-reviews
mailing list