[webkit-reviews] review requested: [Bug 47746] Respect charset in handleDataURL : [Attachment 74968] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 47746: Respect charset in handleDataURL
https://bugs.webkit.org/show_bug.cgi?id=47746

Attachment 74968: Patch
https://bugs.webkit.org/attachment.cgi?id=74968&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
I added an additonal change to the patch (we don't need to declare the default
charset twice).

(In reply to comment #2)
> (From update of attachment 70909 [details])
> Is there a regression test that covers this? If so, where is the patch to the
expected results to show the progression?
The reason for this is, that none of the current ports with a buildbot uses
this functionality.
I've run the GTK LayoutTests on the patch which introduced DataURL.cpp. I
thought GTK uses the curl backend, but this was wrong and so I didn't see the
regression :-(.

I did a small test and changed a port with LayoutTests to use DataURL.cpp: This
patch fixed over 130 layout tests.
So I don't think that we need additional tests. We only need to run the
existing ones.