[webkit-reviews] review granted: [Bug 50097] Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler() to InputTypes : [Attachment 74902] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 50097: Refactor HTMLInputElement: Move a part of
HTMLInputElement::defaultEventHandler() to InputTypes
https://bugs.webkit.org/show_bug.cgi?id=50097

Attachment 74902: Patch
https://bugs.webkit.org/attachment.cgi?id=74902&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74902&action=review

> WebCore/html/InputType.cpp:307
> +	   // Simulate mouse click on the default form button for enter for
these types of elements.

Which types of elements? :) The comment now looks out of place.

Also, passing implicitSubmission bool seems awkward, especially considering you
already have shouldSubmitImplicitly method on this class.