[webkit-reviews] review denied: [Bug 50083] [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback : [Attachment 74881] Fix for the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 26 06:12:47 PST 2010


Xan Lopez <xan.lopez at gmail.com> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 50083: [Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback
https://bugs.webkit.org/show_bug.cgi?id=50083

Attachment 74881: Fix for the bug
https://bugs.webkit.org/attachment.cgi?id=74881&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74881&action=review

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:591
>  

As discussed yesterday in person this is logically wrong, should go in an else
block. Other than that the patch makes sense to me (let's get it in ASAP, it
ASSERTs really frequently).


More information about the webkit-reviews mailing list