[webkit-reviews] review granted: [Bug 50102] IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames : [Attachment 74909] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 26 02:36:03 PST 2010


Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 50102: IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=50102

Attachment 74909: Patch
https://bugs.webkit.org/attachment.cgi?id=74909&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74909&action=review

r=me

> WebCore/storage/IDBDatabaseBackendImpl.cpp:250
> +PassRefPtr<IDBTransactionBackendInterface>
IDBDatabaseBackendImpl::transaction(DOMStringList* storeNames, unsigned short
mode, unsigned long timeout, ExceptionCode&)

rename this to objectStoreNames

> WebKit/chromium/public/WebIDBDatabase.h:64
>	   return WebDOMStringList();

I believe this needs to link back.


More information about the webkit-reviews mailing list