[webkit-reviews] review granted: [Bug 50030] Add an OptionsObject class for IndexedDB (and later GeoLocation) : [Attachment 74858] updated

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 50030: Add an OptionsObject class for IndexedDB (and later GeoLocation)
https://bugs.webkit.org/show_bug.cgi?id=50030

Attachment 74858: updated
https://bugs.webkit.org/attachment.cgi?id=74858&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> > > > > I don't think is the right check. ...
> > > > Will address in later patch.
> > > Sure, if you're confident it doesn't make sense to do it now.
> > What benefit does it give besides a slight perf advantage that would never
be measurable and maybe a slight code cleanliness bump?
> Let's concentrate on this patch.  I'll modify it to work for Geolocation
later.
I pointed it out in this review because it might have made sense to fix it
here. If you'd like to fix it in a later patch, that's fine with me, as I said
above. I was then was confused by your comment about performance, which seems
unrelated.