[webkit-reviews] review denied: [Bug 49927] [GTK] Windowless plugins gets broken key input event (at least in Flash) : [Attachment 74820] Fixed function naming

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 24 18:02:41 PST 2010


Martin Robinson <mrobinson at webkit.org> has denied Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>'s request for review:
Bug 49927: [GTK] Windowless plugins gets broken key input event (at least in
Flash)
https://bugs.webkit.org/show_bug.cgi?id=49927

Attachment 74820: Fixed function naming
https://bugs.webkit.org/attachment.cgi?id=74820&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74820&action=review

Looks really good, though there are still a couple small style issues. Sorry
that I was not explicit about them before.

> WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:266

> +static char
> +keyEventToChar(XKeyEvent *event)

This should be one line and the asterisk should be next to the type name here.


More information about the webkit-reviews mailing list