[webkit-reviews] review denied: [Bug 50045] new-run-webkit-tests: add a --dry-run / -n flag : [Attachment 74811] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 24 17:08:04 PST 2010
Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 50045: new-run-webkit-tests: add a --dry-run / -n flag
https://bugs.webkit.org/show_bug.cgi?id=50045
Attachment 74811: Patch
https://bugs.webkit.org/attachment.cgi?id=74811&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74811&action=review
> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:612
> try:
> - message_broker.run_message_loop()
> + if not self._options.dry_run:
> + message_broker.run_message_loop()
I would put the 'if' outside try/except since the try/except doesn't seem to
apply if it's a dry run.
More information about the webkit-reviews
mailing list