[webkit-reviews] review granted: [Bug 50042] WK2 Context Menu Items need a user data object and a client callback for selection : [Attachment 74801] Patch v1

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Brady Eidson <beidson at apple.com>'s request for
review:
Bug 50042: WK2 Context Menu Items need a user data object and a client callback
for selection
https://bugs.webkit.org/show_bug.cgi?id=50042

Attachment 74801: Patch v1
https://bugs.webkit.org/attachment.cgi?id=74801&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=74801&action=review

> WebKit2/UIProcess/WebPageContextMenuClient.h:42
> +    void customContextMenuItemSelected(WebPageProxy* page, const
WebContextMenuItemData&);

Can omit “page” here.

> WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:92
> +	  
item.setUserData([static_cast<WebUserDataWrapper*>(representedObject)
userData]);

Needs a space before the *.

> WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:144
> +		   WebUserDataWrapper* wrapper = [[WebUserDataWrapper alloc]
initWithUserData:items[i].userData()];

Ditto.