[webkit-reviews] review granted: [Bug 49934] nrwt - add --print-config, clean up create_driver interface : [Attachment 74807] actually pass the tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 24 16:31:08 PST 2010


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49934: nrwt - add --print-config, clean up create_driver interface
https://bugs.webkit.org/show_bug.cgi?id=49934

Attachment 74807: actually pass the tests
https://bugs.webkit.org/attachment.cgi?id=74807&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74807&action=review

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:538
>	   if (not self._driver or self._driver.poll() is not None):

Nit: remove the ()s


More information about the webkit-reviews mailing list