[webkit-reviews] review granted: [Bug 49939] Implement FileWriterSync : [Attachment 74789] Rolled in David's feedback.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 49939: Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49939

Attachment 74789: Rolled in David's feedback.
https://bugs.webkit.org/attachment.cgi?id=74789&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74789&action=review

Please consider a follow up clean up patch. Or just clean this one up and
re-upload (with the reviewed by filled in as me and then get any committer to
cq+ it).

Not cq+ so you can make this decision.

> WebCore/fileapi/DOMFileSystemSync.cpp:94
> +    }

Adding blank lines between methods would be nice.

> WebCore/fileapi/FileWriter.h:59
> +    // FileWriterBase

Nope.

> WebCore/fileapi/FileWriter.h:60
>      void write(Blob* data, ExceptionCode& ec);

remove "ec" in all places.

> WebCore/fileapi/FileWriterBase.h:76
> +    }

blank

> WebCore/fileapi/FileWriterBase.h:77
> +    void seekInternal(long long position);

blank