[webkit-reviews] review granted: [Bug 49940] [Chromium] Implement FileWriterSync : [Attachment 74784] Added a mode for the runloop.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 49940: [Chromium] Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49940

Attachment 74784: Added a mode for the runloop.
https://bugs.webkit.org/attachment.cgi?id=74784&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74784&action=review

> WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp:205
> +   
m_proxy->postTaskForModeToWorkerContext(createCallbackTask(&runTaskOnWorkerThre
ad, this, task), fileWriterOperationsMode);

Ok so this posts to a mode for the sync calls and the async calls. In other
words, it is using a mode for the async calls when it really isn't trying to
post to a nested message loop.

That will work and results in less code...  (it feels mildly odd for some
reason but) ok.