[webkit-reviews] review granted: [Bug 50029] Web Inspector: place local modifications to under original resource nodes in the resource panel. : [Attachment 74769] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 50029: Web Inspector: place local modifications to under original resource
nodes in the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50029

Attachment 74769: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=74769&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74769&action=review

> WebCore/inspector/front-end/Resource.js:639
> +    overrideContent: function(content)

This method should be renamed to setInitialContent

> WebCore/inspector/front-end/SourceView.js:151
> +	   this.resource.content = newContent;

Move this line to _editLineComplete.

> WebCore/inspector/front-end/SourceView.js:155
> +    _editLineComplete: function(scrollTop)

scrollTop is not used.