[webkit-reviews] review denied: [Bug 49927] [GTK] Windowless plugins gets broken key input event (at least in Flash) : [Attachment 74710] Also Fix test plugin

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nicolas Dufresne
<nicolas.dufresne at collabora.co.uk>'s request for review:
Bug 49927: [GTK] Windowless plugins gets broken key input event (at least in
Flash)
https://bugs.webkit.org/show_bug.cgi?id=49927

Attachment 74710: Also Fix test plugin
https://bugs.webkit.org/attachment.cgi?id=74710&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74710&action=review

Just a couple nits.

> WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:266

> +keycode_to_char(XKeyEvent *event)

I think this should be called keyEventToChar since it actually takes an
XKeyEvent and not a keycode. Also, new code should follow WebKit style (event
though the rest of the file doesn't).