[webkit-reviews] review denied: [Bug 50019] Web Inspector: extension API cleanup : [Attachment 74751] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 50019: Web Inspector: extension API cleanup
https://bugs.webkit.org/show_bug.cgi?id=50019

Attachment 74751: patch
https://bugs.webkit.org/attachment.cgi?id=74751&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74751&action=review

> LayoutTests/http/tests/inspector/inspector-test2.js:8
> +    // make sure page-side dispatches are done (e.g. onload in case of
reload) and then

This does not sound right. What does it fix?

> LayoutTests/http/tests/inspector/inspector-test2.js:44
>      if (resultsSynchronized)

What is resultsSynchronized?

> LayoutTests/http/tests/inspector/inspector-test2.js:53
> +    function clearResults()

output serves as a log in our tests. I can't imagine why you might want to
clear it at runtime.