[webkit-reviews] review denied: [Bug 25525] [Gtk] Tooltips should be fully keyboard accessible : [Attachment 72925] Patch to fix tooltip location and text when using the keyboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 24 05:32:05 PST 2010


Xan Lopez <xan.lopez at gmail.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 25525: [Gtk] Tooltips should be fully keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=25525

Attachment 72925: Patch to fix tooltip location and text when using the
keyboard
https://bugs.webkit.org/attachment.cgi?id=72925&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=72925&action=review

r- for always using main frame, which I think is wrong.

> WebKit/gtk/webkit/webkitwebview.cpp:1634
> +

I think you want to use focusedOrMainFrame()from FocusController here?


More information about the webkit-reviews mailing list