[webkit-reviews] review denied: [Bug 49903] [GTK] Inspector: add a way to inspect a WebKitDOMNode : [Attachment 74539] Add webkit_web_inspector_inspect()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 24 03:52:18 PST 2010


Xan Lopez <xan.lopez at gmail.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 49903: [GTK] Inspector: add a way to inspect a WebKitDOMNode
https://bugs.webkit.org/show_bug.cgi?id=49903

Attachment 74539: Add webkit_web_inspector_inspect()
https://bugs.webkit.org/attachment.cgi?id=74539&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74539&action=review

> WebKit/gtk/webkit/webkitwebinspector.cpp:504
> + * @web_inspector: the #WebKitWebInspector that will do the inspection

inspect_node would be better, I agree with Martin.

> WebKit/gtk/webkit/webkitwebinspector.h:26
>  #include <webkit/webkitdefines.h>

You shouldn't include the whole dom header just to use WebKitDOMNode*.
Including webkitdomdefines.h should be enough, I think.


More information about the webkit-reviews mailing list