[webkit-reviews] review granted: [Bug 49971] Web Inspector: pass style id to front-end as Object, not string. : [Attachment 74734] [PATCH] Review comments addressed.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 49971: Web Inspector: pass style id to front-end as Object, not string.
https://bugs.webkit.org/show_bug.cgi?id=49971

Attachment 74734: [PATCH] Review comments addressed.
https://bugs.webkit.org/attachment.cgi?id=74734&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74734&action=review

> WebCore/inspector/InspectorCSSAgent.cpp:285
> +    inspectorStyleSheet->text(result);

this call may fail, should we report such failures to the caller?

> WebCore/inspector/InspectorStyleSheet.h:58
> +	   if (!value->getString("styleSheetId", &m_styleSheetId))

"styleSheetId" is used in at least to places in the code. Please use constants
for property names like this.