[webkit-reviews] review denied: [Bug 49940] [Chromium] Implement FileWriterSync : [Attachment 74620] Chromium bits to implement AsyncFileWriter support for synchronous operations

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 49940: [Chromium] Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49940

Attachment 74620: Chromium bits to implement AsyncFileWriter support for
synchronous operations
https://bugs.webkit.org/attachment.cgi?id=74620&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74620&action=review

> WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp:208
> +	   if (context->thread()->runLoop().runInMode(context,
WorkerRunLoop::defaultMode()) == MessageQueueTerminated)

Don't run a nested loop in defaultMode. It should have a name (and ideally have
a number appended).

See other places where this is done.

Other than that this change looks great!