[webkit-reviews] review denied: [Bug 49779] nrwt multiprocessing - implement first part of broker object : [Attachment 74702] update w/ more review feedback.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 23 16:45:49 PST 2010
Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49779: nrwt multiprocessing - implement first part of broker object
https://bugs.webkit.org/show_bug.cgi?id=49779
Attachment 74702: update w/ more review feedback.
https://bugs.webkit.org/attachment.cgi?id=74702&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
r- for self.name typo.
View in context: https://bugs.webkit.org/attachment.cgi?id=74702&action=review
> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py:65
> + self.name = None
self.name = name?
>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py:110
> +class SingleThreadedBroker(WorkerMessageBroker):
Nit: Should this be an InlineBroker to match the flag name?
More information about the webkit-reviews
mailing list