[webkit-reviews] review granted: [Bug 49944] speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com : [Attachment 74608] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 49944: speculative fix for upload errors: stop using mechanize to upload to
test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=49944

Attachment 74608: Patch
https://bugs.webkit.org/attachment.cgi?id=74608&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74608&action=review

Seems OK to try, but I'm skeptical mechanize itself is the problem.

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.
py:60
> +    for (key, value) in fields:

Nit: no ()s

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.
py:68
> +    for (key, filename, value) in files:

Nit: no ()s

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.
py:97
> +	   for (filename, path) in files:

Nit: no ()s