[webkit-reviews] review canceled: [Bug 49939] Implement FileWriterSync : [Attachment 74618] Webcore implementation, down to the level of AsyncFileWriter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 23 13:23:44 PST 2010


Eric U. <ericu at chromium.org> has canceled Eric U. <ericu at chromium.org>'s
request for review:
Bug 49939: Implement FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=49939

Attachment 74618: Webcore implementation, down to the level of AsyncFileWriter
https://bugs.webkit.org/attachment.cgi?id=74618&action=review

------- Additional Comments from Eric U. <ericu at chromium.org>
Here are the changes between this and the last patch:

[WebKit] diff /tmp/webcore_sync*.patch

Move return outside the #ifdef guard.
330d329
< +	   return true;
331a331
> +	   return true;

Replace "complete" with "true" [copy-paste error].
1139c1139
< +    m_complete = complete;
---
> +    m_complete = true;
1149c1149
< +    m_complete = complete;
---
> +    m_complete = true;


More information about the webkit-reviews mailing list