[webkit-reviews] review granted: [Bug 49498] focus issue with links that have tooltips : [Attachment 74531] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 23 12:35:51 PST 2010


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 49498: focus issue with links that have tooltips
https://bugs.webkit.org/show_bug.cgi?id=49498

Attachment 74531: Updated patch
https://bugs.webkit.org/attachment.cgi?id=74531&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74531&action=review

Looks great. There is only one tiny thing that I'll change before landing.

> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:526
> +    WebKitWebViewPrivate* priv = m_webView->priv;
> +    Node* node = hit.innerNonSharedNode();
> +    priv->tooltipArea = node ? node->getRect() : IntRect();

This should probably just be m_webView->priv->tooltipArea = ... I'll fix that
and land it.


More information about the webkit-reviews mailing list