[webkit-reviews] review denied: [Bug 45436] [Qt] Expose the web security setting. : [Attachment 70386] Fixed comment#10

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Eugene Ostroukhov
<eostroukhov at gmail.com>'s request for review:
Bug 45436: [Qt] Expose the web security setting.
https://bugs.webkit.org/show_bug.cgi?id=45436

Attachment 70386: Fixed comment#10
https://bugs.webkit.org/attachment.cgi?id=70386&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70386&action=review

It looks straigh-forward to me, apart from the binary compatiblity (r- for
that). But I think it would be good if the API documentation would not only say
that this setting is problematic, it should also explain _when_ this setting
_is_ useful after all.

> WebKit/qt/Api/qwebsettings.h:72
> +	   EnforceSameOrigin,

New enum values must be added at the end, otherwise the addition breaks binary
compatibility.