[webkit-reviews] review requested: [Bug 49787] QtWebKit does not respond properly to QInputMethodEvents with replacement text in them. : [Attachment 74643] Patch for WebKit trunk, fixed test regression

[bugzilla-daemon at webkit.org]

Kristian Amlie <kristian.amlie at nokia.com> has asked  for review:
Bug 49787: QtWebKit does not respond properly to QInputMethodEvents with
replacement text in them.
https://bugs.webkit.org/show_bug.cgi?id=49787

Attachment 74643: Patch for WebKit trunk, fixed test regression
https://bugs.webkit.org/attachment.cgi?id=74643&action=review

------- Additional Comments from Kristian Amlie <kristian.amlie at nokia.com>
The previous fix included a patch for respecting preedit text even when there
is committed text. This is correct behavior if you compare with Qt, but it
seems that WebKit doesn't like it. Since this is a noncritical part of the fix,
I simply reverted that to "else if" instead of "if".