[webkit-reviews] review granted: [Bug 49773] nrwt multiprocessing - clean up test sharding a bit, add --workers-are flag : [Attachment 74621] update w/ review feedback, including renaming --workers-are to --worker-model

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 22 18:04:28 PST 2010


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49773: nrwt multiprocessing - clean up test sharding a bit, add
--workers-are flag
https://bugs.webkit.org/show_bug.cgi?id=49773

Attachment 74621: update w/ review feedback, including renaming --workers-are
to --worker-model
https://bugs.webkit.org/attachment.cgi?id=74621&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74621&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-605
> -	   # FIXME: We should use webkitpy.tool.grammar.pluralize here.

Nit: Seems like we should keep this comment, no?


More information about the webkit-reviews mailing list