[webkit-reviews] review denied: [Bug 49934] nrwt - add --print-config, clean up create_driver interface : [Attachment 74590] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49934: nrwt - add --print-config, clean up create_driver interface
https://bugs.webkit.org/show_bug.cgi?id=49934

Attachment 74590: Patch
https://bugs.webkit.org/attachment.cgi?id=74590&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74590&action=review

Some small clarifications . . .

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:123
> +	   optparse.make_option("--print-config", action="store_true",
> +	       default=False, help="Print the config used for the run and
exit."),

Is the expectation to only use this during tests?  It would be nice to not
expose the flag in --help if we don't have to.

> WebKitTools/Scripts/webkitpy/layout_tests/port/port_testcase.py:48
> +    def test_driver_cmd_line(self):
> +	   port = self.make_port()

It looks like this test is only run by mac_unittest.py.  Would it be better to
just move this test into that file and do more validation on the command line
than len > 0?