[webkit-reviews] review denied: [Bug 49780] [chromium] Implement alpha masking for composited layers : [Attachment 74435] Removed ANGLE workaround which is no longer necessary

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 49780: [chromium] Implement alpha masking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=49780

Attachment 74435: Removed ANGLE workaround which is no longer necessary
https://bugs.webkit.org/attachment.cgi?id=74435&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74435&action=review

Looks good. r- because of the needed revert to ChangeLog. Also please consider
something different than the ASSERT_NOT_REACHED + working code in
LayerChromium::bindContentsTexture().

> WebCore/platform/graphics/chromium/LayerChromium.cpp:523
> +    // We don't really expect to call this method for the base layer type.
> +    ASSERT_NOT_REACHED();

That's pretty gross.

> LayoutTests/ChangeLog:8
> +2010-11-18  Vangelis Kokkevis  <vangelis at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Need a short description and bug URL (OOPS!)
> +
> +	   * platform/chromium-gpu/test_expectations.txt:
> +

This file needs to be reverted.