[webkit-reviews] review denied: [Bug 49813] SelectionController::typingStyle() should return EditingStyle* : [Attachment 74416] fixed mac build

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49813: SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Attachment 74416: fixed mac build
https://bugs.webkit.org/attachment.cgi?id=74416&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74416&action=review

> WebCore/editing/EditingStyle.cpp:206
> -    if (!node || !node->parentNode())
> +    if (!node || !node->parentNode() || !m_mutableStyle)

Is this check needed by the refactor or was it needed in the old code too?

> WebCore/editing/EditingStyle.cpp:235
> +    if (shouldPreserveWritingDirection) {

Should there be an == PreserveWritingDirection here?  This looks backwards or
perhaps undefined.