[webkit-reviews] review granted: [Bug 47153] CSS 2.1 failure: at-import-* : [Attachment 74506] Added tests and really fixed 09

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 47153: CSS 2.1 failure: at-import-*
https://bugs.webkit.org/show_bug.cgi?id=47153

Attachment 74506: Added tests and really fixed 09
https://bugs.webkit.org/attachment.cgi?id=74506&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74506&action=review

These tests are strange. Somehow, a syntax requirement of @import being the
first rule (besides @charset) can be waived by semantical correctness of
preceding rules - I wouldn't expect it to work that way.

r=me, but please don't land without confirming that IE and Firefox agree.

> WebCore/ChangeLog:8
> +	   Fix at-import-009.htm by ignoring invalid @media and @charset rules.


Valid or not, @charset is allowed before @import. Could you add an explanation
of what the problem with that was?