[webkit-reviews] review granted: [Bug 49736] For speech input events, send an object containing all the recognition results and metadata. : [Attachment 74243] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 49736: For speech input events, send an object containing all the
recognition results and metadata.
https://bugs.webkit.org/show_bug.cgi?id=49736

Attachment 74243: Patch
https://bugs.webkit.org/attachment.cgi?id=74243&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74243&action=review

r=me

> WebCore/page/SpeechInputEvent.h:42
> +    ~SpeechInputEvent() {}

Please put this and the constructor in a .cpp.	With something like a RefPtr of
Vectors, this could lead to a lot of blow up in .o file size for anything that
includes this file.

> WebCore/page/SpeechInputResultList.h:54
> +    SpeechInputResultList(const SpeechInputResultArray& results)

ditto (and for the ~)