[webkit-reviews] review denied: [Bug 49888] Focused <area> should use CSS properties of <area> instead of associated <img> : [Attachment 74519] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 21 17:51:11 PST 2010


Dave Hyatt <hyatt at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 49888: Focused <area> should use CSS properties of <area> instead of
associated <img>
https://bugs.webkit.org/show_bug.cgi?id=49888

Attachment 74519: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=74519&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Actually I thought about this some more, and since Area is a child of Map,
you'd have to patch HTMLMapElement also (if the area style depended on proper
inheritance from the map style).

I think the other caching mechanism, Element::computedStyle(), will work better
and result in a smaller patch, since it will properly inherit form
HTMLMapElement's computedStyle().

Sorry to make you change things again, but I think removing all the
renderStyle() stuff and just calling computedStyle() instead of styleForElement
will work better.


More information about the webkit-reviews mailing list