[webkit-reviews] review granted: [Bug 49882] Use WTF_ARRAY_LENGTH in WebCore directory : [Attachment 74510] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 21 15:44:35 PST 2010


Csaba Osztrogonac <ossy at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49882: Use WTF_ARRAY_LENGTH in WebCore directory
https://bugs.webkit.org/show_bug.cgi?id=49882

Attachment 74510: Patch
https://bugs.webkit.org/attachment.cgi?id=74510&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74510&action=review

> WebCore/html/canvas/WebGLBuffer.cpp:182
> +    size_t numEntries = WTF_ARRAY_LENGTH(m_maxIndexCache);
> +    for (size_t i = 0; i < numEntries; ++i)

We don't need numEntries variable here. Please fix this before landing:
for (size_t i = 0; i < WTF_ARRAY_LENGTH(m_maxIndexCache); ++i)

Otherwise LGTM.


More information about the webkit-reviews mailing list