[webkit-reviews] review denied: [Bug 49888] Focused <area> should use CSS properties of <area> instead of associated <img> : [Attachment 74516] Patch with test cases
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 21 14:29:35 PST 2010
Dave Hyatt <hyatt at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 49888: Focused <area> should use CSS properties of <area> instead of
associated <img>
https://bugs.webkit.org/show_bug.cgi?id=49888
Attachment 74516: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=74516&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Let's not just make a throwaway render style here. Fix the area element to do
the right thing so we can get the style cached.
That means implementing:
virtual void setRenderStyle(PassRefPtr<RenderStyle>);
and
virtual RenderStyle* nonRendererRenderStyle() const;
Study HTMLOptionElement for an example. This way you want repeatedly request
the style every time you paint, since it will get properly cached.
More information about the webkit-reviews
mailing list